Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -PdisableFirebase to build a non-Firebase build #2980

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 1, 2024

The two flags, -PdisableCrashlytics and -PdisableFirebase are the same,
so consolidate to one flag to avoid confusion.

The two flags, -PdisableCrashlytics and -PdisableFirebase are the same,
so consolidate to one flag to avoid confusion.
@ahmedre ahmedre enabled auto-merge December 1, 2024 10:51
@ahmedre ahmedre added this pull request to the merge queue Dec 1, 2024
Copy link

github-actions bot commented Dec 1, 2024

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │  24.1 MiB │  24.1 MiB │  0 B │  74.7 MiB │  74.7 MiB │  0 B 
     arsc │   2.7 MiB │   2.7 MiB │  0 B │   2.7 MiB │   2.7 MiB │  0 B 
 manifest │   5.8 KiB │   5.8 KiB │  0 B │    28 KiB │    28 KiB │  0 B 
      res │   1.7 MiB │   1.7 MiB │  0 B │     2 MiB │     2 MiB │  0 B 
   native │  18.8 KiB │  18.8 KiB │  0 B │  36.5 KiB │  36.5 KiB │  0 B 
    asset │ 404.2 KiB │ 404.2 KiB │  0 B │ 678.6 KiB │ 678.6 KiB │  0 B 
    other │   218 KiB │   218 KiB │  0 B │ 464.3 KiB │ 464.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  29.2 MiB │  29.2 MiB │  0 B │  80.5 MiB │  80.5 MiB │  0 B 

Merged via the queue into main with commit 96bc3fa Dec 1, 2024
2 checks passed
@ahmedre ahmedre deleted the merge_disable_crashlytics_firebase branch December 1, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant