Python precision #184
Merged
Python precision #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KowerKoint
commented
Nov 22, 2024
| "Vector representation of quantum state.\n\n.. note:: Qubit index is " | ||
| "start from 0. If the amplitudes of $\\ket{b_{n-1}\\dots b_0}$ is " | ||
| "$b_i$, the state is $\\sum_i b_i 2^i$.") | ||
| nb::class_<StateVector<Fp>>(m, |
There was a problem hiding this comment.
#94 からmainに入っているリッチなDocStringを反映
|
ありがとうございます． |
gandalfr-KY
approved these changes
Dec 3, 2024
Glacialte
reviewed
Dec 3, 2024
|
あと、僕もscaluq.f64からでよいと思います |
|
README更新しました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pythonでも好きな精度を選べるようにしました。
現状どうせf64とf32の両方でライブラリがコンパイルされていて、バイナリサイズが大きくなることもなさそうだと思ったので標準で両方サポートしていいと思っています。
今後f16,f32,f128などをサポートするならライブラリのコンパイル時点でオプションで選べるようにすべきそうですが…
のように精度でサブモジュールを切って使えるようにしていますが、
のように1つ上の階層からもデフォルトとしてf64のものを使えるようにするか迷っているので意見がほしいです。
従来通り精度を選ばなくても使えるのがいいところですが、メンテナにとってもユーザーにとっても階層構造がわかりにくくなる懸念があります。