Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-to-util #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sys-to-util #10

wants to merge 1 commit into from

Conversation

bradcgarner
Copy link

line 32 of logger.js required 'sys', which is deprecated. Updated to require 'util'.

@MatthewSH
Copy link

@quirkey any updates on this? Would love to keep logger in my project.

@bradcgarner
Copy link
Author

@MatthewSH I didn't hear back, but logger is working like a charm for me. I forked it and just dropped the code in a file to my codebase with the edit; I'm no longer using it as an NPM dependency. I made one other edit to logger (in my code) after this pull request: changed a system.out.println() to console.log() for the same reason.

@MatthewSH
Copy link

MatthewSH commented May 14, 2018 via email

@ghost
Copy link

ghost commented Jun 8, 2018

I was about to make the same merge request but i'm happy to see someone else did. Hope the author will accept you modifications soon !
But notice the fact that their is a pull request from a branch for this issue since 2012...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants