feat(QueryParser): add support for patterns like "field:*". #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
| )); | ||
| return (None, errors); | ||
| } | ||
| if !json_path.is_empty() && field_type.is_json() { |
There was a problem hiding this comment.
i think this condition is wrong. it generates an error when the json path contains something and the field is json. It should error when there is a path, but the field isn't json (and maybe when there is no path and we're on a json field, i don't remember off hand if tantivy allows things at the root of a json field. I'll edit this comment after verifying)
edit: we don't support putting values at the root of a json field currently, so either it's a json field and there must be a path, or it isn't and there mustn't (though the error messages should likely differ)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog
LogicalLiteralandLogicalAstto supportExistsQuerypattern.