Remove efficientnet-pytorch dependency #1018
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first mentioned this in #918, but we should really remove efficientnet-pytorch for the following reasons:
If we need to ensure backwards compatibility, we can add aliases to the timm implementations.
P.S. I'm also planning on doing this for as many of our other dependencies as I can. I'll wait to see if this PR gets any traction before starting on pretrainedmodels next.