Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epss: add NewFactory() #1462

Merged
merged 1 commit into from
Jan 6, 2025
Merged

epss: add NewFactory() #1462

merged 1 commit into from
Jan 6, 2025

Conversation

daynewlee
Copy link
Contributor

No description provided.

Signed-off-by: daynewlee <[email protected]>
@daynewlee daynewlee requested a review from a team as a code owner January 6, 2025 16:35
@daynewlee daynewlee requested review from crozzy, RTann and hdonnay and removed request for a team January 6, 2025 16:35
@crozzy
Copy link
Contributor

crozzy commented Jan 6, 2025

How are you calling this? Distinct from how Clair instantiates it?

@daynewlee
Copy link
Contributor Author

How are you calling this? Distinct from how Clair instantiates it?

Something like this

updates.WithFactories(map[string]driver.UpdaterSetFactory{
			"epss": epss.NewFactory(),
		}),

@crozzy
Copy link
Contributor

crozzy commented Jan 6, 2025

I'm kind of on the fence if this is needed or can be done by the caller. I suppose it is a helper function that allows for easier API interaction even if it's not directly used by Clair or Claircore.

@RTann
Copy link
Contributor

RTann commented Jan 6, 2025

From what I can tell, it's not required, as I believe you can just do WithOutOfTree(epss.UpdaterSet()) but then the configuration is a bit awkward (you'd have to map the configuration with the name outOfTree)

@daynewlee daynewlee merged commit 61550ea into quay:main Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants