Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tarfs: remove ReadFile #1325

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

BradLugo
Copy link
Contributor

Description

Complete removes ReadFile from tarfs.

Follow up to #1305.

@BradLugo BradLugo self-assigned this Apr 22, 2024
@BradLugo BradLugo requested a review from a team as a code owner April 22, 2024 23:53
@BradLugo BradLugo requested review from crozzy and hdonnay and removed request for a team April 22, 2024 23:53
@BradLugo
Copy link
Contributor Author

I wanted to use this PR to discuss the merits of removing ReadFile entirely from tarfs (see my comment here for more context: #1305 (comment)).

If there is a significant reason to keep ReadFile around, I'll change this PR to expand on testing for it since there are only 1-2 tests currently.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.25%. Comparing base (e31accc) to head (94e3ee6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
- Coverage   56.28%   56.25%   -0.04%     
==========================================
  Files         266      266              
  Lines       16842    16812      -30     
==========================================
- Hits         9480     9458      -22     
+ Misses       6398     6391       -7     
+ Partials      964      963       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hdonnay hdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I can rebase, or you can.

Signed-off-by: Brad Lugo <[email protected]>
@BradLugo BradLugo force-pushed the blugo/remove-readfile branch from b631810 to 94e3ee6 Compare June 13, 2024 20:48
@hdonnay
Copy link
Member

hdonnay commented Jun 13, 2024

/fast-forward

@github-actions github-actions bot merged commit 94e3ee6 into quay:main Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants