enrichers: Load enrichments from jsonblob storage #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
+ Coverage 52.20% 52.43% +0.22%
==========================================
Files 221 221
Lines 16883 16893 +10
==========================================
+ Hits 8813 8857 +44
+ Misses 7259 7224 -35
- Partials 811 812 +1 ☔ View full report in Codecov by Sentry. |
1 task
hdonnay
reviewed
Jan 8, 2024
Comment on lines
+52
to
+61
| var ref uuid.UUID | ||
| if e.Enrichment != nil { | ||
| if ref, err = s.UpdateEnrichments(ctx, e.Updater, e.Fingerprint, e.Enrichment); err != nil { | ||
| return fmt.Errorf("updating enrichements: %w", err) | ||
| } | ||
| } | ||
| if e.Vuln != nil { | ||
| if ref, err = s.UpdateVulnerabilities(ctx, e.Updater, e.Fingerprint, e.Vuln); err != nil { | ||
| return fmt.Errorf("updating vulnerabilities: %w", err) | ||
| } |
There was a problem hiding this comment.
I think this makes it technically possible to have both Vulnerabilites and Enrichments in the same UpdateOperation. Nothing in-tree would produce output that way, so I don't think this is a big deal.
Signed-off-by: J. Victor Martins <[email protected]>
Signed-off-by: J. Victor Martins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patch to fix the following BUG:
claircore/libvuln/jsonblob/jsonblob.go
Lines 94 to 96 in faffb8e