Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] skeleton nextgen network module #1586

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stdweird
Copy link
Member

@stdweird stdweird commented May 5, 2023

No description provided.

@stdweird stdweird marked this pull request as draft May 5, 2023 15:40
@stdweird
Copy link
Member Author

stdweird commented May 5, 2023

@victor-mendoza @aka7 It might be better to use a construct like this to do new work, without having to worry about current ncm-network code or behaviour

if you want to refactor the "old" code so it is easier to manipulate the behaviour, try to do so in separate PR or at least in single commit

@aka7
Copy link
Contributor

aka7 commented May 11, 2023

@stdweird thank you for this. I will use this example to add the NM keyfile format configuration we have been looking at, will share soon for your comments and suggestions.

@stdweird
Copy link
Member Author

@aka7 @victor-mendoza i also added NetworkManager-config-server as an rpm for more backwards compatible behaviour with initscripts

@aka7
Copy link
Contributor

aka7 commented May 15, 2023

@stdweird what I've been working on is fully to configure using keyfile format, rather than getting NM to work with ifcfg files. I'll leave ifcfg compatibility with @victor-mendoza .
I started on this, not yet complete or ready to create PR but your thoughts will be welcomed before I spend anymore time on this.
master...aka7:configuration-modules-core:network_nm

@stdweird
Copy link
Member Author

@aka7 make a PR and set it in draft, so i can comment (even in tests fail). but you only need to add the methods with changes vs network.pm. it looks like you made a full copy now.

@aka7
Copy link
Contributor

aka7 commented May 16, 2023

@stdweird first crack at this. I had copy to methods over to make changes to it.
#1587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants