GraphQL - make sure the panache entities are updated in the index #19883

phillip-kruger · 2021-09-02T19:54:34Z

This PR updates the index used to build the GraphQL schema with the modified panache classes, so that panache and GraphQL can work together.

Signed-off-by:Phillip Kruger [email protected]

cescoffier

LGTM,

What about adding ITs with a Panache entity and a Reactive Panache entity

geoand

I added one big question and one small one.

Also a test case would be nice.

...eployment/src/main/java/io/quarkus/smallrye/graphql/deployment/SmallRyeGraphQLProcessor.java

phillip-kruger · 2021-09-03T08:25:03Z

@cescoffier - I added an integration test

quarkus-bot · 2021-09-06T09:29:01Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `c63e719`

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 16	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 16 #

- Failing: integration-tests/vault-agroal

📦 integration-tests/vault-agroal

✖ io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

✖ io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

✖ io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

Signed-off-by: Phillip Kruger <[email protected]>

quarkus-bot · 2021-09-06T14:22:16Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `366d49b`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Failures	Logs	Raw logs
✖	Native Tests - Data1	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver integration-tests/mongodb-panache

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityTest.testAddDeleteDefaultTenant line 53 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityTest.testPostFruitDefaultTenant line 92 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityTest.testUpdateFruitDefaultTenant line 127 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

📦 integration-tests/mongodb-panache

✖ io.quarkus.it.mongodb.panache.transaction.MongodbPanacheTransactionTest.testTheEndpoint line 95 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <3>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 16 #

- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver integration-tests/mongodb-panache

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityTest.testAddDeleteDefaultTenant line 53 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityTest.testPostFruitDefaultTenant line 92 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityTest.testUpdateFruitDefaultTenant line 127 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

📦 integration-tests/mongodb-panache

✖ io.quarkus.it.mongodb.panache.transaction.MongodbPanacheTransactionTest.testTheEndpoint line 95 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <3>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ Native Tests - Data1 #

- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityInGraalITCase.testAddDeleteDefaultTenant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityInGraalITCase.testPostFruitDefaultTenant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityInGraalITCase.testUpdateFruitDefaultTenant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

quarkus-bot · 2021-09-06T17:46:41Z

Failing Jobs - Building `366d49b`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Failures	Logs	Raw logs
✖	Native Tests - Data1	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver integration-tests/mongodb-panache

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityTest.testAddDeleteDefaultTenant line 53 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityTest.testPostFruitDefaultTenant line 92 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityTest.testUpdateFruitDefaultTenant line 127 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

📦 integration-tests/mongodb-panache

✖ io.quarkus.it.mongodb.panache.transaction.MongodbPanacheTransactionTest.testTheEndpoint line 95 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <3>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 16 #

- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver integration-tests/mongodb-panache

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityTest.testAddDeleteDefaultTenant line 53 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityTest.testPostFruitDefaultTenant line 92 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityTest.testUpdateFruitDefaultTenant line 127 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

📦 integration-tests/mongodb-panache

✖ io.quarkus.it.mongodb.panache.transaction.MongodbPanacheTransactionTest.testTheEndpoint line 95 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <3>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ Native Tests - Data1 #

- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityInGraalITCase.testAddDeleteDefaultTenant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityInGraalITCase.testPostFruitDefaultTenant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityInGraalITCase.testUpdateFruitDefaultTenant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

phillip-kruger · 2021-09-07T11:22:47Z

@gsmet - the test failures is unrelated, and running the ci again, still fails. Is it ok to merge ?

phillip-kruger · 2021-09-07T13:15:02Z

@geoand - I think gsmet is on PTO, maybe you can help. The build failures is not related, and running the ci again does not fix it. Can I merge ? Or should I rebase ?

gsmet · 2021-09-07T13:19:41Z

I'm not :).

I confirm the failures are unrelated and has been fixed. Also they did not cause anything to be skipped so it should be safe enough to merge this.

I haven't looked at what it does, though :)

phillip-kruger · 2021-09-07T13:23:44Z

Great ! Thanks @gsmet . This "updates" the Jandex index for GraphQL (only) so that the updated panache classes is in the index, and when used with GraphQL actually works. I was reviewed by @Ladicek and parts of this PR might move to Jandex, and then we will update this again. For how GraphQL use Jandex at the moment, this is safe, but might need more testing for other cases once it moved to Jandex.

enbohm

@phillip-kruger after upgrading from 2.2.3.Final to 2.3.0.Final I keep getting the following stack trace while tests are trying to start in dev-mode (mvn quarkus:dev). Building and running outside dev-mode works just fine so I first spotted this during hot-reload and tests tried to start. Since 2.3.0.Final is not released yet I maybe should wait reporting this but maybe this is a known issue? Downgrading to 2.2.3.Final everything works fine. Looks related to the new classes added here (OverridabeIndex.java). I can try to create a small reproducer if needed.

java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.smallrye.graphql.deployment.SmallRyeGraphQLProcessor#buildExecutionService threw an exception: java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because the return value of "org.jboss.jandex.MethodParameterInfo.name()" is null
at io.quarkus.smallrye.graphql.deployment.OverridableIndex$7.compare(OverridableIndex.java:160)
at io.quarkus.smallrye.graphql.deployment.OverridableIndex$7.compare(OverridableIndex.java:155)
at io.quarkus.smallrye.graphql.deployment.OverridableIndex$8.compare(OverridableIndex.java:199)
at io.quarkus.smallrye.graphql.deployment.OverridableIndex$8.compare(OverridableIndex.java:168)
at java.base/java.util.TreeMap.compare(TreeMap.java:1570)
at java.base/java.util.TreeMap.addEntryToEmptyMap(TreeMap.java:776)
at java.base/java.util.TreeMap.put(TreeMap.java:785)
at java.base/java.util.TreeMap.put(TreeMap.java:534)
at java.base/java.util.TreeSet.add(TreeSet.java:255)
at java.base/java.util.AbstractCollection.addAll(AbstractCollection.java:336)
at java.base/java.util.TreeSet.addAll(TreeSet.java:309)
at io.quarkus.smallrye.graphql.deployment.OverridableIndex.overrideCollection(OverridableIndex.java:239)
at io.quarkus.smallrye.graphql.deployment.OverridableIndex.getAnnotations(OverridableIndex.java:69)
at io.smallrye.graphql.schema.helper.SourceOperationHelper.scanAllSourceAnnotations(SourceOperationHelper.java:50)
at io.smallrye.graphql.schema.helper.SourceOperationHelper.(SourceOperationHelper.java:29)
at io.smallrye.graphql.schema.creator.type.AbstractCreator.addOperations(AbstractCreator.java:115)
at io.smallrye.graphql.schema.creator.type.AbstractCreator.create(AbstractCreator.java:76)
at io.smallrye.graphql.schema.creator.type.TypeCreator.create(TypeCreator.java:34)
at io.smallrye.graphql.schema.creator.type.AbstractCreator.create(AbstractCreator.java:32)
at io.smallrye.graphql.schema.SchemaBuilder.createAndAddToSchema(SchemaBuilder.java:219)
at io.smallrye.graphql.schema.SchemaBuilder.addTypesToSchema(SchemaBuilder.java:153)
at io.smallrye.graphql.schema.SchemaBuilder.generateSchema(SchemaBuilder.java:121)
at io.smallrye.graphql.schema.SchemaBuilder.build(SchemaBuilder.java:86)
at io.quarkus.smallrye.graphql.deployment.SmallRyeGraphQLProcessor.buildExecutionService(SmallRyeGraphQLProcessor.java:207)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.deployment.ExtensionLoader$2.execute(ExtensionLoader.java:820)
at io.quarkus.builder.BuildContext.run(BuildContext.java:277)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
at java.base/java.lang.Thread.run(Thread.java:833)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)

phillip-kruger · 2021-10-04T09:24:03Z

Hi @enbohm - Do you have a small reproducer ?

enbohm · 2021-10-04T09:26:48Z

@phillip-kruger Only have production code but I'll try to create a reproducer today or tomorrow. Will keep you posted

phillip-kruger · 2021-10-04T09:29:28Z

Great ! Thanks :)

enbohm · 2021-10-05T06:22:44Z

@phillip-kruger I can now reproduce this issue but it might be me bad; when specifying the maven-compiler-plugin v.3.8.1 in pom.xml it seems to be working (see below). Without explicit setting the version, which I hadn't, my default maven-compiler-plugin version was 3.1 which seems to cause the above stacktrace. So apparently I had a misconfiguration but not sure if it is documented at quarkus.io that this version is required? Anyway since it is working now I guess there is no point creating an issue for this.

<plugin>
        <artifactId>maven-compiler-plugin</artifactId>
        <version>3.8.1</version>
</plugin>

phillip-kruger · 2021-10-05T06:43:21Z

Great ! Thanks

phillip-kruger requested review from FroMage, cescoffier, mkouba and geoand September 2, 2021 19:54

quarkus-bot bot added area/graphql area/smallrye labels Sep 2, 2021

phillip-kruger requested a review from Ladicek September 3, 2021 06:00

cescoffier approved these changes Sep 3, 2021

View reviewed changes

geoand reviewed Sep 3, 2021

View reviewed changes

...eployment/src/main/java/io/quarkus/smallrye/graphql/deployment/SmallRyeGraphQLProcessor.java Outdated Show resolved Hide resolved

...eployment/src/main/java/io/quarkus/smallrye/graphql/deployment/SmallRyeGraphQLProcessor.java Show resolved Hide resolved

GraphQL - make sure the panache entities are updated in the index

366d49b

Signed-off-by: Phillip Kruger <[email protected]>

phillip-kruger requested a review from geoand September 6, 2021 12:10

geoand approved these changes Sep 6, 2021

View reviewed changes

phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 6, 2021

phillip-kruger merged commit 2602229 into quarkusio:main Sep 7, 2021

quarkus-bot bot added this to the 2.3 - main milestone Sep 7, 2021

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 7, 2021

phillip-kruger deleted the graphql-panache-issue branch September 7, 2021 14:48

phillip-kruger mentioned this pull request Sep 9, 2021

Add support for public fields instead of getters smallrye/smallrye-graphql#1026

Closed

enbohm reviewed Oct 4, 2021

View reviewed changes

Ladicek mentioned this pull request May 18, 2022

Add a "stacked" composite index smallrye/jandex#142

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GraphQL - make sure the panache entities are updated in the index #19883

GraphQL - make sure the panache entities are updated in the index #19883

phillip-kruger commented Sep 2, 2021

cescoffier left a comment

geoand left a comment •

edited

Loading

phillip-kruger commented Sep 3, 2021

quarkus-bot bot commented Sep 6, 2021 •

edited

Loading

Failing Jobs - Building `c63e719`

Failures

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/vault-agroal

quarkus-bot bot commented Sep 6, 2021 •

edited

Loading

Failing Jobs - Building `366d49b`

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

📦 integration-tests/mongodb-panache

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

📦 integration-tests/mongodb-panache

⚙️ Native Tests - Data1 #

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

quarkus-bot bot commented Sep 6, 2021

phillip-kruger commented Sep 7, 2021

phillip-kruger commented Sep 7, 2021

gsmet commented Sep 7, 2021

phillip-kruger commented Sep 7, 2021

enbohm left a comment

phillip-kruger commented Oct 4, 2021

enbohm commented Oct 4, 2021

phillip-kruger commented Oct 4, 2021

enbohm commented Oct 5, 2021 •

edited

Loading

phillip-kruger commented Oct 5, 2021

GraphQL - make sure the panache entities are updated in the index #19883

GraphQL - make sure the panache entities are updated in the index #19883

Conversation

phillip-kruger commented Sep 2, 2021

cescoffier left a comment

Choose a reason for hiding this comment

geoand left a comment • edited Loading

Choose a reason for hiding this comment

phillip-kruger commented Sep 3, 2021

quarkus-bot bot commented Sep 6, 2021 • edited Loading

Failing Jobs - Building c63e719

Failures

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/vault-agroal

quarkus-bot bot commented Sep 6, 2021 • edited Loading

Failing Jobs - Building 366d49b

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

📦 integration-tests/mongodb-panache

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

📦 integration-tests/mongodb-panache

⚙️ Native Tests - Data1 #

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

quarkus-bot bot commented Sep 6, 2021

Failing Jobs - Building 366d49b

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

📦 integration-tests/mongodb-panache

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

📦 integration-tests/mongodb-panache

⚙️ Native Tests - Data1 #

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

phillip-kruger commented Sep 7, 2021

phillip-kruger commented Sep 7, 2021

gsmet commented Sep 7, 2021

phillip-kruger commented Sep 7, 2021

enbohm left a comment

Choose a reason for hiding this comment

phillip-kruger commented Oct 4, 2021

enbohm commented Oct 4, 2021

phillip-kruger commented Oct 4, 2021

enbohm commented Oct 5, 2021 • edited Loading

phillip-kruger commented Oct 5, 2021

geoand left a comment •

edited

Loading

quarkus-bot bot commented Sep 6, 2021 •

edited

Loading

Failing Jobs - Building `c63e719`

quarkus-bot bot commented Sep 6, 2021 •

edited

Loading

Failing Jobs - Building `366d49b`

Failing Jobs - Building `366d49b`

enbohm commented Oct 5, 2021 •

edited

Loading