Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Update QOSDK to 6.3.3 #1019

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

metacosm
Copy link
Contributor

@metacosm metacosm commented Nov 4, 2023

Make sure that you have run ./mvnw -Dsync and included the changes in your pull request (preferably in the same commit, unless it makes sense to do otherwise).

Thanks!

@metacosm
Copy link
Contributor Author

metacosm commented Nov 4, 2023

/cc @aloubyansky @gsmet

Copy link

quarkus-bot bot commented Nov 4, 2023

Failing Jobs - Building 2032a4f

Status Name Step Failures Logs Raw logs Build scan
Check generated project has been updated Check that generated project is properly updated ⚠️ Check → Logs Raw logs

@metacosm
Copy link
Contributor Author

metacosm commented Nov 6, 2023

Not sure what this needs, I did run ./mvnw -Dsync before opening the PR (and did so again, just now, to double check), and there isn't any more changes to commit.

@aloubyansky aloubyansky changed the title Update QOSDK to 6.3.3 [3.2] Update QOSDK to 6.3.3 Nov 6, 2023
@aloubyansky
Copy link
Member

It's because you have the Gradle Maven repo enabled in your settings while it's not enabled in the CI and most of our local configs, it results in gradle-tooling-api added to the quarkus-bom.

@metacosm
Copy link
Contributor Author

metacosm commented Nov 6, 2023

Hmm, I don't recall doing anything specific. I'm not even sure what this "Gradle Maven repo" is supposed to refer to, to be honest… What do I need to do to fix the issue?

@aloubyansky
Copy link
Member

It seems like you have https://repo.gradle.org/artifactory/libs-releases or a mirror of it enabled in your settings. If you disable it it should fix the check.

@metacosm
Copy link
Contributor Author

metacosm commented Nov 8, 2023

I don't, though. cat ~/.m2/settings.xml | grep gradle returns nothing. Or if I do, I have no idea where it is and I certainly didn't set it up.

@metacosm
Copy link
Contributor Author

metacosm commented Nov 8, 2023

Of note, I've opened several similar PRs with the exact same configuration without issue before so I don't know why this would failing now.

@aloubyansky
Copy link
Member

And if you re-sync it it's still the same?

@metacosm
Copy link
Contributor Author

metacosm commented Nov 8, 2023

And if you re-sync it it's still the same?

yes

@metacosm
Copy link
Contributor Author

metacosm commented Nov 8, 2023

Hmm, that said, the PR was opened by a bot, so it probably has different settings than I do. That said, this also isn't the first PR opened by the bot either so 🤷🏼

@aloubyansky aloubyansky merged commit 05cc9b7 into quarkusio:3.2 Nov 8, 2023
2 of 3 checks passed
@metacosm metacosm deleted the qosdk-6.3.3 branch November 8, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants