Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image of Google quantum computer #6902

Closed
wants to merge 2 commits into from

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Dec 31, 2024

This adds a resized image from quantumai.google. The original file name was "hero-heading-mobile". The SVG version simply embeds a base64-encoded version of the jpg. The SVG version is useful on GitHub because GitHub's support for reStructuredText is so wonky. GitHub doesn't respect :align: right for .. image:: directives if the file is a jpeg/png/tiff etc, but GitHub does respect it if the file is in SVG format – even if the SVG content is actually just an image! So if you want to right-align an image using pure RST constructs, wrapping it in SVG makes it possible.

@CirqBot CirqBot added the size: S 10< lines changed <50 label Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@5ffb3ad). Learn more about missing BASE report.
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6902   +/-   ##
=======================================
  Coverage        ?   97.86%           
=======================================
  Files           ?     1084           
  Lines           ?    94299           
  Branches        ?        0           
=======================================
  Hits            ?    92289           
  Misses          ?     2010           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhucka mhucka marked this pull request as ready for review December 31, 2024 20:21
@mhucka mhucka requested review from vtomole and a team as code owners December 31, 2024 20:21
@mhucka mhucka requested a review from maffoo December 31, 2024 20:21
@mhucka mhucka enabled auto-merge (squash) December 31, 2024 20:22
@mhucka mhucka self-assigned this Dec 31, 2024
@mhucka mhucka requested a review from pavoljuhas January 7, 2025 16:35
@mhucka
Copy link
Contributor Author

mhucka commented Jan 9, 2025

Per discussion with @dstrain115 today, we're removing this image for the time being. We need to check with relevant QAI leadership about what images we are allowed to use on non-Google-hosted sites like GitHub.

@mhucka mhucka closed this Jan 9, 2025
auto-merge was automatically disabled January 9, 2025 04:01

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants