Issue 148: add newtype for column and row indices. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeTemp
force-pushed
the
issue-148_add-newtype-for-cols-and-rows-2
branch
from
88f6356
to
4eaaa0b
Compare
qrilka
reviewed
Aug 31, 2022
|
Also it looks like the merged in #158 brought some conflicts with this one |
LukeTemp
force-pushed
the
issue-148_add-newtype-for-cols-and-rows-2
branch
from
cd50f32
to
af848aa
Compare
LukeTemp
commented
Sep 7, 2022
LukeTemp
force-pushed
the
issue-148_add-newtype-for-cols-and-rows-2
branch
from
af848aa
to
439fae7
Compare
qrilka
reviewed
Sep 8, 2022
qrilka
reviewed
Sep 8, 2022
|
thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a newtype for column and row to improve the type safety and readability of the code: #148