Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newtype for column and row indexes #148

Open
jappeace opened this issue Oct 20, 2021 · 0 comments
Open

Add newtype for column and row indexes #148

jappeace opened this issue Oct 20, 2021 · 0 comments

Comments

@jappeace
Copy link
Contributor

This will allow us to create smart constructors that check for values < 1.
These causes issues in excel (nasty warnings which give users the impression they're being hacked!)
Furthermore new types around these will no longer cause accidental confusion between rows and columns.

See discussion:
https://github.com/qrilka/xlsx/pull/144/files#r693388304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant