Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix estimated time #216

Merged
merged 1 commit into from
Mar 19, 2019
Merged

fix estimated time #216

merged 1 commit into from
Mar 19, 2019

Conversation

lnw
Copy link
Contributor

@lnw lnw commented Mar 19, 2019

  1. fix wrong ETA, and make obvious why there is a factor
  2. replace multiple divisions by multiplications (so it is obvious that the order of execution is irrelevant)

bast
bast approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@bast bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bast bast merged commit 681a0bc into qmcurrents:master Mar 19, 2019
@heikef
Copy link
Contributor

heikef commented Mar 19, 2019

Is this solving as well issue #170 ? Thanks for you effort, Lukas!

@lnw
Copy link
Contributor Author

lnw commented Mar 19, 2019

No, that is unrelated. #170 is about wrong final times in case of OMP, but this patch just fixes the estimated time that is printed at the beginning of a run.

@heikef
Copy link
Contributor

heikef commented Mar 19, 2019

Ok. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bast bast bast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lnw @heikef @bast