Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove typography default props #595

Merged
merged 1 commit into from
Jul 25, 2024
Merged

feat: remove typography default props #595

merged 1 commit into from
Jul 25, 2024

Conversation

Oakerin
Copy link
Collaborator

@Oakerin Oakerin commented Jul 24, 2024

Адаптация компонентов типографии под Next.js

Задача выросла из следующего предупреждения

Warning: Heading: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

Если при интеграции с кошельком никаких проблем не вылезет, планирую удалить defaultProps во всех компонентах

Changes

Отказ от defaultProps в пользу JavaScript default parameters

  • New code is covered by tests
  • All the changes are mentioned in docs (readme.md)

@antongolub antongolub requested a review from dimonka83 July 25, 2024 01:17
@dimonka83 dimonka83 changed the title [RF] Typography: уход от defaultProps для работы с nextjs feat(typography): remove default props Jul 25, 2024
@dimonka83 dimonka83 changed the title feat(typography): remove default props feat: remove typography default props Jul 25, 2024
@AlekseyShatohin AlekseyShatohin self-requested a review July 25, 2024 07:44
@dimonka83 dimonka83 merged commit 7e37854 into master Jul 25, 2024
12 checks passed
@dimonka83 dimonka83 deleted the next branch July 25, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants