Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add placement prop for DropDown #574

Merged
merged 1 commit into from
Sep 25, 2023
+3 −1
Merged

feat: add placement prop for DropDown #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/desktop/src/main/ts/drop-down/DropDown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export interface DropDownProps {
maxWidth?: Value
rootClose?: boolean
stub?: boolean
placement?: OverlayProps['placement']
target: OverlayProps['target']
container: OverlayProps['container']
children: ReactElement
Expand Down Expand Up @@ -56,6 +57,7 @@ export const DropDown: FC<DropDownProps> = ({
maxWidth,
rootClose = true,
stub = false,
placement = 'bottom',
target,
container,
onHide,
Expand All @@ -67,7 +69,7 @@ export const DropDown: FC<DropDownProps> = ({
) : (
<Overlay
show={show}
placement="bottom"
placement={placement}
target={target}
container={container}
rootClose={rootClose}
Expand Down
Loading