[NF] @ROLE for elements Accordion, Content, Breadcrumbs

qiwi · Aug 6, 2019 · fe03732 · fe03732
1 parent 1046aa5
commit fe03732
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 1 deletion.
diff --git a/packages/desktop/src/block-accordion/BlockAccordion.tsx b/packages/desktop/src/block-accordion/BlockAccordion.tsx
@@ -29,6 +29,7 @@ export const BlockAccordion: FunctionComponent<
   BlockAccordionProps<BlockAccordionItemModel>
 > = ({items, indent = 'm', tabIndex = 0, opened, onChange}) => (
   <AccordionControl<BlockAccordionItemModel>
+
     items={items}
     opened={opened}
     onChange={onChange}
@@ -37,6 +38,8 @@ export const BlockAccordion: FunctionComponent<
         {renderProps.items.map((item, index) => (
           <Card
             key={index}
+            role="article"
+            aria-label={typeof item.title === 'string' ? item.title : undefined}
             s={
               item.hovered || item.focused
                 ? '0 0 16px 0 rgba(0, 0, 0, 0.12)'

diff --git a/packages/desktop/src/block-content/BlockContent.tsx b/packages/desktop/src/block-content/BlockContent.tsx
@@ -14,6 +14,8 @@ const BlockContentIdent: { [indent in NonNullable<BlockContentProps['indent']>]:
 
 export const BlockContent: FC<BlockContentProps> = ({indent = 'm', children}) => (
   <Box
+    role="section"
+    aria-label="content"
     p={BlockContentIdent[indent]}
     children={children}
   />

diff --git a/packages/desktop/src/breadcrumbs/Breadcrumbs.tsx b/packages/desktop/src/breadcrumbs/Breadcrumbs.tsx
@@ -13,7 +13,7 @@ export const Breadcrumbs: FC<BreadcrumbsProps> = ({children}) => (
       <Fragment key={i} >
         {i > 0 ? (
           <Fragment>
-            <Box as="span" mx={2} display="inline">
+            <Box as="span" mx={2} display="inline" role="section">
               &#8226;
             </Box>
             &shy;

diff --git a/packages/mobile/src/block-accordion/BlockAccordion.tsx b/packages/mobile/src/block-accordion/BlockAccordion.tsx
@@ -28,6 +28,8 @@ export const BlockAccordion: FunctionComponent<
         {renderProps.items.map((item, index) => (
           <Card
             key={index}
+            role="article"
+            aria-label={typeof item.title === 'string' ? item.title : undefined}
             s={
               index > 0
                 ? '0 -1px 0 #e6e6e6'

diff --git a/packages/mobile/src/block-content/BlockContent.tsx b/packages/mobile/src/block-content/BlockContent.tsx
@@ -13,6 +13,8 @@ const BlockContentIdent: { [indent in NonNullable<BlockContentProps['indent']>]:
 
 export const BlockContent: FC<BlockContentProps> = ({indent = 'm', children}) => (
   <Box
+    role="section"
+    aria-label="content"
     p={BlockContentIdent[indent]}
     children={children}
   />