-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QHC-846] Solve Layout problems & Update qibo version transpiler #869
base: adding_optimize_transpiled_gates
Are you sure you want to change the base?
[QHC-846] Solve Layout problems & Update qibo version transpiler #869
Conversation
AI AnalysisReview:The changes in the test files seem to focus on improving fixture organization and ensuring input validation for the QDAC-II class, which enhances the test coverage and reliability. The modifications in circuit_transpiler.py and qdevil_qdac2.py to use integer keys and define ramping rate ranges respectively show a clear effort to enhance code clarity and maintainability. Overall, these changes appear to improve the codebase by enforcing stricter validation and consistency.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## adding_optimize_transpiled_gates #869 +/- ##
====================================================================
- Coverage 97.30% 97.29% -0.02%
====================================================================
Files 231 231
Lines 8274 8266 -8
====================================================================
- Hits 8051 8042 -9
- Misses 223 224 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TODOs in this and next PRs:
Solve more buggs about final layout/compute it yourself? 🔥🔥🔥
Improve readability of layout 🔥🔥🔥: