[QHC-840] Raise an error if qdac input values are outside of the range

[flavie-lebars]

No description provided.

[linear]

QHC-840 Limit QDAC and SPI ramping rate

[pullpo-for-slack]

🔗Pullpo.io Slack channel

[pullpo-for-slack]

AI Analysis

Review:

The addition of a check to ensure the ramping rate falls within the valid range before setting it on a channel is a good practice to prevent errors and maintain data integrity. This change shows attention to detail and enhances the robustness of the code.

Detailed file changes

(dropdown):

In qdevil_qdac2.py:

• Added a check to ensure ramping rate is within the valid range before setting the rate on a channel.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.30%. Comparing base (872e0b8) to head (0c54472).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #865   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files         231      231           
  Lines        8273     8281    +8     
=======================================
+ Hits         8050     8058    +8     
  Misses        223      223           

Flag	Coverage Δ
unittests	97.30% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fedonman]

Great job and great tests! Left a minor comment, and is ready to go.

[fedonman]

Great work!