Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live plotting #842

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Live plotting #842

wants to merge 44 commits into from

Conversation

jordivallsq
Copy link
Contributor

@jordivallsq jordivallsq commented Dec 2, 2024

Added live plotinside experiment class

Copy link

linear bot commented Dec 2, 2024

QHC-799 Live plotting

Copy link

🔗Pullpo.io Slack channel

@pullpo-for-slack pullpo-for-slack bot requested a review from DZPM December 2, 2024 10:53
@DZPM DZPM removed their request for review December 2, 2024 10:53
Copy link
Collaborator

@jjmartinezQT jjmartinezQT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to produce an example of usage so Oscar can review this functionality and give feedback before merging into main.

src/qililab/qprogram/experiment_executor.py Outdated Show resolved Hide resolved
src/qililab/qprogram/experiment_executor.py Outdated Show resolved Hide resolved
@pullpo-for-slack pullpo-for-slack bot requested a review from fedonman December 2, 2024 11:01
@jordivallsq jordivallsq self-assigned this Dec 4, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 24 lines in your changes missing coverage. Please review.

Project coverage is 97.02%. Comparing base (6eb37b1) to head (b731b89).

Files with missing lines Patch % Lines
src/qililab/result/experiment_live_plot.py 66.66% 23 Missing ⚠️
src/qililab/result/experiment_results_writer.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   97.28%   97.02%   -0.27%     
==========================================
  Files         231      232       +1     
  Lines        8218     8304      +86     
==========================================
+ Hits         7995     8057      +62     
- Misses        223      247      +24     
Flag Coverage Δ
unittests 97.02% <75.75%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fedonman fedonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice implementation! 💯 💯 Left some comments on first glance, and will do a recheck later.

src/qililab/result/experiment_live_plot.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
src/qililab/result/experiment_live_plot.py Outdated Show resolved Hide resolved
src/qililab/result/experiment_live_plot.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants