Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QHC-697] Adding Calibration checkpoints #777

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

GuillermoAbadLopez
Copy link
Contributor

@GuillermoAbadLopez GuillermoAbadLopez commented Aug 16, 2024

TODOs of PR:

  • Implement the main idea of the checkpoints algorithm
  • Implement Comparison of fidelity in output dictionary and values in node.check_value
  • Test this, with concrete mock notebooks
  • Write quick docstrings
  • Cover functionality with tests
  • Write better docstrings

Also some other checks:

  • Make sure is backwards compatible, if no checkpoints are passed
  • Make sure weird cases indeed work correctly, like green checkpoints after red ones...

NEW TODOs:

  • Do test of full flow run_automaitc_calibration, with the permutations of V and X, for both checkpoints
  • End the unit test of diagnose with the checkpoints 👌

@GuillermoAbadLopez GuillermoAbadLopez self-assigned this Aug 16, 2024
@GuillermoAbadLopez GuillermoAbadLopez marked this pull request as draft August 16, 2024 01:20
@GuillermoAbadLopez GuillermoAbadLopez changed the title Adding Calibration checkpoints [QHC-697] Adding Calibration checkpoints Aug 16, 2024
Copy link

linear bot commented Aug 16, 2024

@GuillermoAbadLopez GuillermoAbadLopez marked this pull request as ready for review August 23, 2024 10:59
Copy link

Hello. You may have forgotten to update the changelog!
Please edit changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.28%. Comparing base (6eb37b1) to head (ef3ec61).

Files with missing lines Patch % Lines
src/qililab/calibration/calibration_controller.py 97.67% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         231      231           
  Lines        8218     8257   +39     
=======================================
+ Hits         7995     8033   +38     
- Misses        223      224    +1     
Flag Coverage Δ
unittests 97.28% <98.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IsaacLA12
Copy link
Contributor

Remember to add a test of the diagnose method as I believe is not covered rn

@IsaacLA12
Copy link
Contributor

After careful review, testing it with edge cases, hand to hand with @GuillermoAbadLopez, I believe it is good to go.
Leaving my aprove but adding software testing is needed to pass codecov and also test it on HW when available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants