Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup React component testing #326

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BenediktSeidlSWM
Copy link
Contributor

This pull request contains some basic setup for testing React components using the "React Testing Library" [1] and Jest. Note that the babel config file needs to be renamed in order for babel to consider the node_modules folder. [2]

Before writing more tests in this style, I would like to hear from you if this kind of testing is desirable for the qwc2 project. Thanks!

tests/components/SearchBox.test.jsx Fixed Show resolved Hide resolved
@manisandro
Copy link
Member

Thanks for your work on this! I'd say this is definitely desirable.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@BenediktSeidlSWM
Copy link
Contributor Author

It seems like I broke ci by renaming eslint.yml to ci.yml. Would you prefer separate jobs for linting and testing? Also, please note that I introduced SARIF_ESLINT_IGNORE_SUPPRESSED so that eslint errors that are disabled inline no longer show up on GitHub.

@manisandro
Copy link
Member

Maybe it's easier to keep them separate? SARIF_ESLINT_IGNORE_SUPPRESSED looks good to me.

The parameter SARIF_ESLINT_IGNORE_SUPPRESSED in eslint.yml prevents
that errors that are disabled inline still show up on GitHub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants