-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup React component testing #326
base: master
Are you sure you want to change the base?
Conversation
af5009c
to
3e9c0b1
Compare
3e9c0b1
to
2d48580
Compare
Thanks for your work on this! I'd say this is definitely desirable. |
0a57951
to
d5bc966
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
It seems like I broke ci by renaming |
Maybe it's easier to keep them separate? |
The parameter SARIF_ESLINT_IGNORE_SUPPRESSED in eslint.yml prevents that errors that are disabled inline still show up on GitHub.
d5bc966
to
4ad2e23
Compare
This pull request contains some basic setup for testing React components using the "React Testing Library" [1] and Jest. Note that the babel config file needs to be renamed in order for babel to consider the
node_modules
folder. [2]Before writing more tests in this style, I would like to hear from you if this kind of testing is desirable for the qwc2 project. Thanks!