Skip to content

Commit

Permalink
fix(portforward): service start error not treated as critical
Browse files Browse the repository at this point in the history
A service start error can happen if the service is started after the Wireguard VPN tunnel is up, but the tunnel does not work. The VPN is then internally restarted, causing the service start error, so it should not be treated as a critical error.
  • Loading branch information
qdm12 committed Oct 7, 2023
1 parent 6c639fc commit 1c43a1d
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions internal/portforward/loop.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,6 @@ func (l *Loop) run(runCtx context.Context, runDone chan<- struct{},
// and if it failed to start.
updateResult <- err
}
if err != nil {
if runCtx.Err() == nil { // crashed but NOT stopped
runErrorCh <- fmt.Errorf("starting new service: %w", err)
}
return
}
}
}

Expand Down

0 comments on commit 1c43a1d

Please sign in to comment.