Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PageOrder setting as part of PageLayoutOptions #2022

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

imirkin
Copy link
Contributor

@imirkin imirkin commented Nov 7, 2024

This controls whether page numbers are assigned in a zig-zag going across first, or down first.

How Has This Been Tested

Verified that opening in Excel shows the "over then down" value, whereas "down then over" is used by default.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This controls whether page numbers are assigned in a zig-zag going
across first, or down first.
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. LGTM. Your last PR exported new function SetLegacyDrawingHF, I think rename it to SetHeaderFooterImage would be better, how about you think? You can change it in this PR if you think so.

@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 7, 2024
@imirkin
Copy link
Contributor Author

imirkin commented Nov 7, 2024

Thanks for your PR. LGTM. Your last PR exported new function SetLegacyDrawingHF, I think rename it to SetHeaderFooterImage would be better, how about you think? You can change it in this PR if you think so.

I think that's fine, but I'd prefer to keep the changes separate. Can I send a different PR to update it?

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (b7375bc) to head (807b724).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2022   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          32       32           
  Lines       29880    29895   +15     
=======================================
+ Hits        29642    29657   +15     
  Misses        158      158           
  Partials       80       80           
Flag Coverage Δ
unittests 99.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuri
Copy link
Member

xuri commented Nov 7, 2024

Thanks for your PR. LGTM. Your last PR exported new function SetLegacyDrawingHF, I think rename it to SetHeaderFooterImage would be better, how about you think? You can change it in this PR if you think so.

I think that's fine, but I'd prefer to keep the changes separate. Can I send a different PR to update it?

Of course, sure. Thanks.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes based on your branch, to reduce cyclomatic complexity, added value check and error message for each option.

…tion is invalid

- Add a new exported error variable `ErrPageSetupAdjustTo`
- Updated unit tests
@xuri xuri added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2024
@xuri xuri merged commit d2be5cd into qax-os:master Nov 8, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Features
Development

Successfully merging this pull request may close these issues.

2 participants