-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PageOrder setting as part of PageLayoutOptions #2022
Conversation
This controls whether page numbers are assigned in a zig-zag going across first, or down first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. LGTM. Your last PR exported new function SetLegacyDrawingHF
, I think rename it to SetHeaderFooterImage
would be better, how about you think? You can change it in this PR if you think so.
I think that's fine, but I'd prefer to keep the changes separate. Can I send a different PR to update it? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2022 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 32 32
Lines 29880 29895 +15
=======================================
+ Hits 29642 29657 +15
Misses 158 158
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Of course, sure. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes based on your branch, to reduce cyclomatic complexity, added value check and error message for each option.
…tion is invalid - Add a new exported error variable `ErrPageSetupAdjustTo` - Updated unit tests
This controls whether page numbers are assigned in a zig-zag going across first, or down first.
How Has This Been Tested
Verified that opening in Excel shows the "over then down" value, whereas "down then over" is used by default.
Types of changes
Checklist