Fix stretching integer data #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mraspaud
reviewed
Nov 24, 2023
trollimage/xrimage.py
Outdated
Comment on lines
1100
to
1101
| if np.issubdtype(dtype, np.integer): | ||
| dtype = np.dtype(np.float32) |
There was a problem hiding this comment.
Shouldn't this be float64 if the input type is int32? the mantissa in float32 in 24bits, so it can't represent the full spectrum of values from int32...
There was a problem hiding this comment.
The handling is adjusted in d35a5ac
There was a problem hiding this comment.
And fixed in 034d659 . The previous attempt entered the wrong branch.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 91.48% 91.50% +0.02%
==========================================
Files 12 12
Lines 3956 3969 +13
==========================================
+ Hits 3619 3632 +13
Misses 337 337
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes stretching of linear integer data. The bug was introduced in #150 due to lack of testing.
uint8data gives unexpected results #152 (remove if there is no corresponding issue, which should only be the case for minor changes)git diff origin/master **/*py | flake8 --diff(remove if you did not edit any Python files)