Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy 2 dtype issues #76

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Fix numpy 2 dtype issues #76

merged 5 commits into from
Jun 26, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jun 26, 2024

Downstream tests are failing in Satpy regarding dtype, but it only seems to be Windows so far. Let's see how CI behaves here.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@djhoese djhoese added the bug label Jun 26, 2024
@djhoese djhoese self-assigned this Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.94%. Comparing base (c248ff4) to head (f151c94).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   88.34%   87.94%   -0.40%     
==========================================
  Files          21       20       -1     
  Lines        1467     1452      -15     
==========================================
- Hits         1296     1277      -19     
- Misses        171      175       +4     
Flag Coverage Δ
unittests 87.94% <100.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 87.233% (-0.3%) from 87.492%
when pulling 91e38ca on djhoese:debug-np2-dtype
into 9f01b70 on pytroll:main.

@coveralls
Copy link

Coverage Status

coverage: 87.233% (-0.3%) from 87.492%
when pulling 6cb3711 on djhoese:debug-np2-dtype
into 9f01b70 on pytroll:main.

@coveralls
Copy link

Coverage Status

coverage: 87.233% (-0.3%) from 87.492%
when pulling f151c94 on djhoese:debug-np2-dtype
into 9f01b70 on pytroll:main.

@djhoese djhoese marked this pull request as ready for review June 26, 2024 15:58
@djhoese djhoese merged commit f643607 into pytroll:main Jun 26, 2024
20 of 23 checks passed
@djhoese djhoese deleted the debug-np2-dtype branch June 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants