-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python versions in deploy ci #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Do we keep 3 or four versions in other packages?
Hmm, 3.10 is not shown in the active checks. |
Idk, we have 3.9, 3.11, and 3.12 in the ci.yaml, so I wasn't really sure |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 88.31% 88.31%
=======================================
Files 21 21
Lines 1464 1464
=======================================
Hits 1293 1293
Misses 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
we should have 3.10, 3.11 and 3.12 right? |
The config now has 3.9, 3.10, 3.11 and 3.12, but the 3.10 is missing from the active tests. |
.github/workflows/deploy.yaml
Outdated
@@ -34,7 +34,7 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
os: [windows-latest, macos-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm, where's "ubuntu-latest"? It is listed in current main
: https://github.com/pytroll/python-geotiepoints/blob/main/.github/workflows/ci.yaml#L12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that was deploy.yaml
, not ci.yaml
.
Ok should be better now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might as well drop Python 3.9 support in the setup.py then.
Whoa I didn't realize this package hadn't switched to cibuildwheel yet. We should really do that, but I'm not sure I have time today. Will look into it more after I've actually woken up. |
Good point, on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll merge this, but leave any releases up to you unless you ask me to.
This PR fixes the python versions for the deploy script of the ci