Fix rsr plotting to allow for similar (overlapping) bands

[adybbroe]

Fix the script to plot spectral response functions, allowing for similar (overlapping) bands - and don't just ignore all others than the first found.

• Closes #xxxx
• Tests added
• Tests passed: Passes pytest pyspectral
• Passes flake8 pyspectral
• Fully documented
• Add your name to AUTHORS.md if not there already

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (279c2c2) to head (8ca1082).
Report is 16 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files          22       22           
  Lines        2515     2515           
=======================================
  Hits         2270     2270           
  Misses        245      245           

Flag	Coverage Δ
unittests	90.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adybbroe]

For instance, now you can do:

%> python bin/composite_rsr_plot.py --platform_name Meteosat-11 Meteosat-12 NOAA-21 --sensor seviri fci viirs -r 10.5 12.5 -v --exclude_bandnames I5

Which will produce this plot:

Leaving out the last --exclude_bandnames option above would have resultet in this plot:

[djhoese]

Maybe it's just me but those quicklooks aren't working. They still say "Uploading ...png...". Did you maybe close the tab before they were fully uploaded?

[djhoese]

required is not necessary here. The default is False. Actually type=str is also not necessary as str is the default type.

[djhoese]

Small change requested. I don't understand the code before or after this PR so I'm not sure I should give my opinion too strongly. The code "smells" like there should be a simpler way, but if it works for you then 👍.

Possible simplification: Could you have a function that gets all the bands needed to be plotted and would take the wavelength and band information in as input and produce a list of bands?

[simonrp84]

LGTM! I'm not expert enough to figure out how to do what Dave asks but they appear like reasonable suggestions if you have time. If not, happy to see it merged as-is.

[adybbroe]

Maybe it's just me but those quicklooks aren't working. They still say "Uploading ...png...". Did you maybe close the tab before they were fully uploaded?

You were right, sorry, should work now

[djhoese]

@adybbroe Can you fix the title of the PR. It got cut off from your commit message it seems.

For your quicklooks, yes I see them, but now I'm not sure what you are trying to show. Prior to this PR the code would just ignore I5? Or would it fail because two wavelengths matched for a single VIIRS instrument?

And now? Now you don't need the exclude I5 because it can be plotted without issue?

[adybbroe]

Small change requested. I don't understand the code before or after this PR so I'm not sure I should give my opinion too strongly. The code "smells" like there should be a simpler way, but if it works for you then 👍.

Possible simplification: Could you have a function that gets all the bands needed to be plotted and would take the wavelength and band information in as input and produce a list of bands?

I believe you have a sharp nose! I think you might be right. Will think another day on this, and either start simplify, or merge and make an issue, or just merge :-)