-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scipy 1.14 compatibility and trapz usage #228
Conversation
Numpy 2 used np.float64 wavelength as reason to upcast.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
- Coverage 90.00% 89.82% -0.19%
==========================================
Files 23 23
Lines 2571 2535 -36
==========================================
- Hits 2314 2277 -37
- Misses 257 258 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
FYI for you @adybbroe when you find time to review this: A lot of the test changes are because numpy 2's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice with the more compact tests!
I was actually not aware that trapz was deprecated. I think we keep the try-except for now.
CC @arcanerr
The scipy.integrate.trapz function is deprecated. This adds a try/except around importing trapezoid versus trapz. I'm not sure how long we want to keep this workaround as
trapezoid
has been around since at least January of 2023 from what I can tell in git.pytest pyspectral
flake8 pyspectral