norm and pca_lowrank op info test from issue #7528 #8384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added norm and pca_lowrank implementations for op test, however currently the lowarnk_pca test fails because of :
FAILED test/test_ops.py::TestOpInfoCPU::test_reference_eager_pca_lowrank_cpu_float32 - AssertionError: Tensor-likes are not close!
Upon checking with debug print statements, I saw that the only case it doesn't match is because of sign ambiguity here:
That is the only fix remaining, and then it should be good to go.