Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPO Recipe Doc #2091

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Conversation

SalmanMohammadi
Copy link
Collaborator

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)
   .-.                                                   \ /
  ( (                                |                  - * -
   '-`                              -+-                  / \
            \            o          _|_          \
            ))          }^{        /___\         ))
          .-#-----.     /|\     .---'-'---.    .-#-----.
     ___ /_________\   //|\\   /___________\  /_________\
    /___\ |[] _ []|    //|\\    | A /^\ A |    |[] _ []| _.O,_
....|"#"|.|  |*|  |...///|\\\...|   |"|   |....|  |*|  |..(^)....

Copy link

pytorch-bot bot commented Nov 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2091

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 95fb989 with merge base b5d2e63 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 28, 2024
@SalmanMohammadi SalmanMohammadi mentioned this pull request Nov 28, 2024
44 tasks
Copy link
Contributor

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments, but looks good.

docs/source/recipes/dpo.rst Outdated Show resolved Hide resolved
docs/source/recipes/dpo.rst Outdated Show resolved Hide resolved
docs/source/recipes/dpo.rst Outdated Show resolved Hide resolved
@SalmanMohammadi SalmanMohammadi merged commit 32e265d into pytorch:main Nov 28, 2024
16 checks passed
@SalmanMohammadi SalmanMohammadi deleted the dpo_recipe_docs branch November 28, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants