-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate SimpoLoss
#2063
Deprecate SimpoLoss
#2063
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2063
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ef23321 with merge base f3d8d3c (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2063 +/- ##
==========================================
+ Coverage 7.35% 65.60% +58.24%
==========================================
Files 277 323 +46
Lines 15422 17963 +2541
==========================================
+ Hits 1135 11785 +10650
+ Misses 14287 6178 -8109 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
The deprecated wrapper is messing with the isinstance check in the recipe - should we remove this loss? Or warn in the recipe (bad)? |
I've removed from the recipe. If the user tries to use this loss in the recipe, it will display the deprecation warning and error out (in a probably unhelpful way). |
Context
What is the purpose of this PR? Is it to
Closes #2062. We could link to an example repo in a follow up.
Changelog
Added a deprecation message. To be removed in 0.6.