Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SimpoLoss #2063

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Conversation

SalmanMohammadi
Copy link
Collaborator

@SalmanMohammadi SalmanMohammadi commented Nov 25, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (deprecation)

Closes #2062. We could link to an example repo in a follow up.

Changelog

Added a deprecation message. To be removed in 0.6.

Copy link

pytorch-bot bot commented Nov 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2063

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ef23321 with merge base f3d8d3c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.60%. Comparing base (f3d8d3c) to head (0140dc5).

Additional details and impacted files
@@            Coverage Diff             @@
##            main    #2063       +/-   ##
==========================================
+ Coverage   7.35%   65.60%   +58.24%     
==========================================
  Files        277      323       +46     
  Lines      15422    17963     +2541     
==========================================
+ Hits        1135    11785    +10650     
+ Misses     14287     6178     -8109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@SalmanMohammadi
Copy link
Collaborator Author

The deprecated wrapper is messing with the isinstance check in the recipe - should we remove this loss? Or warn in the recipe (bad)?

@SalmanMohammadi
Copy link
Collaborator Author

I've removed from the recipe. If the user tries to use this loss in the recipe, it will display the deprecation warning and error out (in a probably unhelpful way).

@SalmanMohammadi SalmanMohammadi merged commit 0fdc4f0 into pytorch:main Nov 28, 2024
17 checks passed
@SalmanMohammadi SalmanMohammadi deleted the deprecate_simpo branch November 28, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate SimPOLoss
5 participants