Fix check in load_from_full_state_dict for modified state dicts
#1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1967
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ff29b2f with merge base 506e099 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65343473 |
|
Looks good to me, but lint is failing |
RylanC24
added a commit
to RylanC24/torchtune
that referenced
this pull request
Nov 7, 2024
…ytorch#1967) Summary: This is a change to the OSS torchtune library Differential Revision: D65343473
RylanC24
force-pushed
the
export-D65343473
branch
from
52dc278 to
be94439
Compare
RylanC24
added a commit
to RylanC24/torchtune
that referenced
this pull request
Nov 7, 2024
…ytorch#1967) Summary: This is a change to the OSS torchtune library Differential Revision: D65343473
RylanC24
force-pushed
the
export-D65343473
branch
from
be94439 to
f186d1f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65343473 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65343473 |
…ytorch#1967) Summary: This is a change to the OSS torchtune library Differential Revision: D65343473
RylanC24
force-pushed
the
export-D65343473
branch
from
f186d1f to
ff29b2f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65343473 |
RdoubleA
approved these changes
Nov 7, 2024
RdoubleA
changed the title
load_from_full_state_dict for modified state dicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is a change to the OSS torchtune library
Differential Revision: D65343473