-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Llama Vision PEFT #1937
base: main
Are you sure you want to change the base?
Llama Vision PEFT #1937
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1937
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8d960b5 with merge base e1caa9f (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
# if key == "decoder.layers.3.layer.attn.q_proj.lora_a.weight": | ||
# import pdb; pdb.set_trace() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
@@ -635,6 +635,7 @@ def save_checkpoint( | |||
) | |||
|
|||
if training.ADAPTER_KEY in state_dict: | |||
# import pdb; pdb.set_trace() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run a forward parity check please. Only one comment, otherwise looks good
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses. #1779
Changelog
What are the changes made in this PR?
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test