Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing vestigial mistral reward model converter references #1307

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

SalmanMohammadi
Copy link
Collaborator

I must've missed this in #1160.

Copy link

pytorch-bot bot commented Aug 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1307

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f68672f with merge base c1fabb9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.75%. Comparing base (f6ddfcc) to head (f68672f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
+ Coverage   68.31%   70.75%   +2.43%     
==========================================
  Files         255      258       +3     
  Lines       11796    11904     +108     
==========================================
+ Hits         8059     8423     +364     
+ Misses       3737     3481     -256     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SalmanMohammadi SalmanMohammadi merged commit 3955b33 into pytorch:main Aug 11, 2024
20 checks passed
@SalmanMohammadi SalmanMohammadi deleted the cleaning_mistral_init branch August 20, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants