-
Notifications
You must be signed in to change notification settings - Fork 23k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Storage _use_count API in Python #139426
base: gh/janeyx99/200/base
Are you sure you want to change the base?
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139426
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 3615247 with merge base 33dce10 (): BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: 54f77ee5f1fd28f67d1c7889a244be799e7a46e6 Pull Request resolved: #139426
Needed by pytorch/torchtune#1936 In favor over #139109, as exposing an existing API is better than adding a new one (and this enables a more robust fix) [ghstack-poisoned]
ghstack-source-id: 30622d3e144f4877ba46266ab5a80b88ffe6f071 Pull Request resolved: #139426
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 mandatory check(s) failed. The first few are:
Dig deeper by viewing the failures on hud |
Needed by pytorch/torchtune#1936 In favor over #139109, as exposing an existing API is better than adding a new one (and this enables a more robust fix) [ghstack-poisoned]
ghstack-source-id: e67fe62f07599847b7652cac0ca264cc3f2701d8 Pull Request resolved: #139426
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / build Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -f "broken trunk and mac build timeout don’t look like my fault" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot revert -m 'Sorry for reverting your change, but it is failing some inductor job in trunk' -c nosignal test_torch.py::TestTorch::test_storage__use_count_APIs_align GH job link HUD commit link |
@pytorchbot successfully started a revert job. Check the current status here. |
@janeyx99 your PR has been successfully reverted. |
This reverts commit e31136d. Reverted #139426 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but it is failing some inductor job in trunk ([comment](#139426 (comment)))
Would be nice to replace the torch._C._storage_Use_Count call in pytorch/torchtune#1936, at least without needing to know about _cdata in OSS code. Initially keeping it private as Tensor._use_count is also private. In favor over pytorch#139109 in solving the same problem, as exposing an existing API is better than adding a new one (and this enables a more robust fix) Pull Request resolved: pytorch#139426 Approved by: https://github.com/soulitzer
This reverts commit e31136d. Reverted pytorch#139426 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but it is failing some inductor job in trunk ([comment](pytorch#139426 (comment)))
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Would be nice to replace the torch._C._storage_Use_Count call in pytorch/torchtune#1936, at least without needing to know about _cdata in OSS code.
Initially keeping it private as Tensor._use_count is also private.
In favor over #139109 in solving the same problem, as exposing an existing API is better than adding a new one (and this enables a more robust fix)
Stack from ghstack (oldest at bottom):