Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sme2 detection for aarch64 #262

Merged
merged 18 commits into from
Sep 26, 2024
Merged

Add sme2 detection for aarch64 #262

merged 18 commits into from
Sep 26, 2024

Conversation

gonnet
Copy link
Contributor

@gonnet gonnet commented Sep 24, 2024

Add cpuinfo_has_arm_sme2 for aarch64.

Implemented using the values used here.

This also required changing the type of the variables used to store/pass the value of hwcap2 from uint32_t to uint64_t, since the flag for sme2 is at bit 37.

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix some nits I commented. I can merge it once you update. Thanks.

include/cpuinfo.h Outdated Show resolved Hide resolved
src/arm/linux/api.h Show resolved Hide resolved
@gonnet
Copy link
Contributor Author

gonnet commented Sep 26, 2024

This is now good to go!

@digantdesai digantdesai merged commit 1e83a2f into pytorch:main Sep 26, 2024
12 checks passed
gonnet added a commit to gonnet/cpuinfo that referenced this pull request Oct 22, 2024
I forgot to add this for `mach` when I did it for `linux` a while back (pytorch#262).

I could not find `hw.optional.arm.FEAT_SME_*` features for all the `sme`-related bits in `cpuinfo_arm_isa`, but I've added the ones I could find.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants