Add .clang-format to enforce project style #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanthswami
force-pushed
the
add-clang-format
branch
from
fef247d to
29b81d8
Compare
|
Are we opinionated about the clang-format version? By default, the Github action tracks to version 13, but we could set it higher. Edit: I'll stick with -13. PyTorch seems to default to an open-source -12 version. At the very least, we can track this workflow's version for now. It's not too hard to change later, if desired. |
prashanthswami
force-pushed
the
add-clang-format
branch
from
29b81d8 to
7530a42
Compare
prashanthswami
force-pushed
the
add-clang-format
branch
3 times, most recently
from
81522a1 to
06241e0
Compare
malfet
reviewed
Jan 5, 2024
prashanthswami
force-pushed
the
add-clang-format
branch
from
06241e0 to
b0a5230
Compare
The settings here match the current settings for the pytorch/pytorch project, with the exception that 8-character-width tabs are preferred in place of spaces.
prashanthswami
force-pushed
the
add-clang-format
branch
3 times, most recently
from
be35b1b to
92046ee
Compare
Now that we have a clang-format file defined, clean up all usages once.
prashanthswami
force-pushed
the
add-clang-format
branch
from
92046ee to
8748832
Compare
Enforce clang-format consistency on all new changes.
prashanthswami
force-pushed
the
add-clang-format
branch
from
8748832 to
1adef20
Compare
malfet
approved these changes
Jan 6, 2024
markdryan
added a commit
to markdryan/cpuinfo
that referenced
this pull request
Jan 11, 2024
PR pytorch#204 broke the RISC-V build by including for a second time a header file that currently only exists in the RISC-V Android NDK. The header is not yet available in mainstream Linux distributions. The header in question, <sys/hwprobe.h>, is already included when building for Android at the top of riscv-hw.c so the second include is unnecessary and can be safely removed.
malfet
pushed a commit
that referenced
this pull request
Jan 22, 2024
PR #204 broke the RISC-V build by including for a second time a header file that currently only exists in the RISC-V Android NDK. The header is not yet available in mainstream Linux distributions. The header in question, <sys/hwprobe.h>, is already included when building for Android at the top of riscv-hw.c so the second include is unnecessary and can be safely removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings here match the current settings for the pytorch/pytorch project, with the exception that 8-character-width tabs are preferred in place of spaces.
In addition to adding .clang-format, we also run it once on the whole code-base to clean up the existing usages.
Review: @malfet
CC: @GlassOfWhiskey