Build magma without conda and push tarball #2026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afrittoli
force-pushed
the
magma_tarball
branch
2 times, most recently
from
a8f3f09
to
746c97c
Compare
First step towards removing conda from magma builds. This still relies on the python conda image to do the builds, as that image already contains the required dependencies and various versions of cuda. Use a build script to build magma, instead of conda-build, to produce the binary tarball without the rest of the conda package. Upload the package to downloads.pytorch.org instead of the anaconda pytorch channel (TBD). This will require an update to the "install_conda.sh" script so that magma can be installed from that tarball directly. Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
force-pushed
the
magma_tarball
branch
from
746c97c
to
2e5d128
Compare
|
superseded by pytorch/pytorch#139888 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards removing
condafrom Magma builds.This still relies on the python conda image to build, as that image already contains the required dependencies and various versions of cuda.
Use a build script to build magma, instead of conda-build, to produce the binary tarball without the rest of the conda package. An alternative approach could be to produce a no-python wheel, which we could consider if we needed to maintain multi-arch versions of this.
Upload the package to downloads.pytorch.org instead of the anaconda pytorch channel (TBD).
This will require updating the "install_conda.sh" script so that magma can be installed directly from that tarball.