Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RobustRelevancePursuitSingleTaskGP with specialized fit_gpytorch_mll #2690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SebastianAment
Copy link
Contributor

Summary: This commit introduces an abstract RobustRelevancePursuitModel and RobustRelevancePursuitSingleTaskGP, a specific implementation of the abstract class. The main purpose of the new class is to provide an identical interface to a canonical SingleTaskGP, but automatically extend the likelihood with the SparseOutlierGaussianLikelihood, and toggle the Relevance Pursuit algorithm automatically through the marginal likelihood optimization via fit_gpytorch_mll by dispatching on the model type. This makes the model and algorithm easy to use.

Differential Revision: D68353582

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68353582

Summary: This commit introduces an abstract `RobustRelevancePursuitModel` and `RobustRelevancePursuitSingleTaskGP`, a specific implementation of the abstract class. The main purpose of the new class is to provide an identical interface to a canonical `SingleTaskGP`, but automatically extend the likelihood with the `SparseOutlierGaussianLikelihood`, and toggle the Relevance Pursuit algorithm automatically through the marginal likelihood optimization via `fit_gpytorch_mll` by dispatching on the model type. This makes the model and algorithm easy to use.

Differential Revision: D68353582
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68353582

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 92.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 99.95%. Comparing base (589260b) to head (1a08ddb).

Files with missing lines Patch % Lines
botorch/models/robust_relevance_pursuit_model.py 91.78% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2690      +/-   ##
==========================================
- Coverage   99.98%   99.95%   -0.04%     
==========================================
  Files         200      201       +1     
  Lines       18232    18305      +73     
==========================================
+ Hits        18230    18297      +67     
- Misses          2        8       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants