Pin scipy to <1.15 (again) to avoid slowdowns #2669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appear to be substantial slowdowns with the optimization (presumably both for fitting and candidate generation) with scipy 1.15: pytorch#2668 This pins the scipy version to <1.15 for now to avoid these slowdowns and terrible user experiences (at least on the `main` branch) until we've figured out the root cause of these slowdowns.
facebook-github-bot
added
the
CLA Signed
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2669 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 200 200
Lines 18155 18155
=======================================
Hits 18153 18153
Misses 2 2 ☔ View full report in Codecov by Sentry. |
saitcakmak
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appear to be substantial slowdowns with the optimization (presumably both for fitting and candidate generation) with scipy 1.15: #2668
This pins the scipy version to <1.15 for now to avoid these slowdowns and terrible user experiences (at least on the
mainbranch) until we've figured out the root cause of these slowdowns.