Unnecessary "# pyright: ignore" rule: "reportUnknownMemberType #13393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i remove Unnecessary "# pyright: ignore" rule: "reportUnknownMemberType"
Update metadata.py
|
Thanks! Unfortunately, it looks like these are in fact necessary, and removing them makes our CI fail :-) There was a bug in our GitHub workflow where the relevant workflow was running on pushes to |
|
@AlexWaygood Will I be able to resend the PR again. If the GitHub workflow bug is resolved ? |
|
The GitHub workflow bug is resolved -- I fixed it in #13394. Now that the GitHub workflow bug is fixed, it demonstrates that these changes are incorrect, and that applying these changes causes our CI to fail. We won't merge a PR that causes our CI to fail :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i remove Unnecessary "# pyright: ignore" rule: "reportUnknownMemberType"