gh-128731: Fix ResourceWarning in robotparser.RobotFileParser.read() #128733
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
Jan 11, 2025
•
serhiy-storchaka
commented
- Issue: ResourceWarning in test_robotparser #128731
serhiy-storchaka
added
needs backport to 3.12
picnixz
reviewed
Jan 12, 2025
Misc/NEWS.d/next/Library/2025-01-11-13-40-12.gh-issue-128731.qpKlai.rst
Outdated
Show resolved
Hide resolved
picnixz
approved these changes
Jan 12, 2025
sobolevn
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
The warning is gone with this change:
» ./python.exe -m test test_robotparser
Using random seed: 3011282491
0:00:00 load avg: 3.90 Run 1 test sequentially in a single process
0:00:00 load avg: 3.90 [1/1] test_robotparser
== Tests result: SUCCESS ==
1 test OK.
Total duration: 81 ms
Total tests: run=60 skipped=1
Total test files: run=1/1
Result: SUCCESS
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 12, 2025
…ead() (pythonGH-128733) (cherry picked from commit 5e65a1a) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-128755 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 12, 2025
…ead() (pythonGH-128733) (cherry picked from commit 5e65a1a) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-128756 is a backport of this pull request to the 3.12 branch. |
|
GH-128755 is a backport of this pull request to the 3.13 branch. |
|
GH-128756 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jan 12, 2025
…otFileParser.read() (GH-128733) (GH-128756) (cherry picked from commit 5e65a1a) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.