gh-128729: Fix RuntimeWarning in test_unittest #128730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
Jan 11, 2025
•
serhiy-storchaka
commented
- Issue: RuntimeWarning in test_unittest #128729
serhiy-storchaka
added
needs backport to 3.12
serhiy-storchaka
changed the title
graingert
reviewed
Jan 11, 2025
Lib/test/test_unittest/test_case.py
Outdated
| @@ -346,8 +346,12 @@ class Foo(unittest.TestCase): | |||
| async def test1(self): | |||
| return 1 | |||
|
|
|||
| with self.assertWarns(DeprecationWarning) as w: | |||
| Foo('test1').run() | |||
| with warnings.catch_warnings(): | |||
There was a problem hiding this comment.
I think neater to use check_warnings: f0490ab (#128726)
There was a problem hiding this comment.
The RuntimeWarning is less important for this test.
I think that check_warnings is too heavy for this. It requires to repeat the DeprecationWarning message.
sobolevn
approved these changes
Jan 12, 2025
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka
removed
needs backport to 3.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.