-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-127947: Repeat PyREPL key events on Windows when wRepeatCount > 1 #127948
base: main
Are you sure you want to change the base?
Conversation
Keys that are repeated into PyREPL were typed only once. This change makes those characters be typed the correct number of times.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to see new contributors :)
Could you add a test? See the devguide for how to write tests.
Misc/NEWS.d/next/Library/2024-12-14-16-28-33.gh-issue-127947.2W5rYh.rst
Outdated
Show resolved
Hide resolved
By simulating INPUT_RECORD being received
There was no test coverage for the |
I'll review this soon-ish. Could you deal with the merge conflicts in the meantime? |
I see #128389 has caused a merge conflict. The changes there are minimal, but it isn't marked as getting backported to 3.13. |
Nah, backporting is pretty easy even if the automation fails. Just deal with the conflicts on main and you're good. |
The one thing I'm not sure about is the current distinction between |
Keys that are repeated into PyREPL were typed only once on Windows.
This has been consistently happening when typing a dead key repeatedly, such as when double-pressing the quote character on the US International keyboard layout.
This change makes those characters be typed the correct number of times.
wRepeatCount
on Windows, causing incorrect 'dead key' behavior #127947