Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-127559: Fix platform selection for _freeze_module.vcxproj #127560

Closed
wants to merge 10 commits into from

Conversation

smurav
Copy link
Contributor

@smurav smurav commented Dec 3, 2024

_freeze_module uses wrong platform Win32 when I pass x64 platform to build.bat
Other projects use $(Platform).

@smurav
Copy link
Contributor Author

smurav commented Dec 3, 2024

Due to a build issue on the ARM64 platform, the behavior can only be fixed for the x64 platform.

@zooba
Copy link
Member

zooba commented Dec 4, 2024

The issue on ARM64 is because the original code is correct, and you are making an incorrect change.

There's nothing to fix here. If you want _freeze_module to run as a native x64 binary, then request it by setting PreferredToolArchitecture=x64 before you build.

@zooba zooba closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants