Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-123345: improve fnmatch docs #123346

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Aug 26, 2024

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 26, 2024
@picnixz picnixz changed the title gh-123215: improve fnmatch docs gh-123345: improve fnmatch docs Aug 26, 2024
@picnixz picnixz requested a review from barneygale November 15, 2024 13:14
Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@picnixz
Copy link
Member Author

picnixz commented Dec 15, 2024

Friendly ping in case you forgot to hit "merge" @barneygale

@picnixz picnixz merged commit 29fe807 into python:main Jan 13, 2025
25 checks passed
@picnixz picnixz deleted the improve-fnmatch-docs branch January 13, 2025 10:21
@picnixz picnixz added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jan 13, 2025
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 13, 2025
(cherry picked from commit 29fe807)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 13, 2025

GH-128775 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 13, 2025
(cherry picked from commit 29fe807)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 13, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 13, 2025

GH-128776 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 13, 2025
picnixz added a commit that referenced this pull request Jan 13, 2025
gh-123345: improve `fnmatch` docs (GH-123346)
(cherry picked from commit 29fe807)

Co-authored-by: Bénédikt Tran <[email protected]>
picnixz added a commit that referenced this pull request Jan 13, 2025
gh-123345: improve `fnmatch` docs (GH-123346)
(cherry picked from commit 29fe807)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.13 has failed when building commit 05bd6cb.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1396/builds/794) and take a look at the build logs.
  4. Check if the failure is related to this commit (05bd6cb) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1396/builds/794

Failed tests:

  • test.test_concurrent_futures.test_thread_pool

Failed subtests:

  • test_free_reference - test.test_concurrent_futures.test_thread_pool.ThreadPoolExecutorTest.test_free_reference

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 131, in test_free_reference
    self.assertIsNone(wr())
    ~~~~~~~~~~~~~~~~~^^^^^^
AssertionError: <test.test_concurrent_futures.executor.MyObject object at 0x20002070090> is not None


Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 131, in test_free_reference
    self.assertIsNone(wr())
    ~~~~~~~~~~~~~~~~~^^^^^^
AssertionError: <test.test_concurrent_futures.executor.MyObject object at 0x20004070090> is not None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants