gh-118761: Improve import time of pprint
#122725
Merged
+23
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves import time by up to seven times. Measured with a PGO and LTO non-debug build on macOS.
The slowest import in
pprint
isdataclasses
(taking 0.0012s / 55.2% of import time), and used in only two functions.After deferring
dataclasses
, the next isre
(0.005s / 30.1% of the new import time), only used in one function.After deferring
re
, the next arecollections
(0.002s / 14.8%) andtypes
(0.000s / 2.4%). I left these, as their times are low and they're less straightforward to defer.-X importtime
Running:
pip install tuna && ./python.exe -X importtime -c 'import pprint' 2> import.log && tuna import.log
total import time: 0.022s -> 0.011s = x2 as fast
main
pprint
import time: 0.014s -> 0.002s = x7 as fastmain
hyperfine: 19.2 ms -> 10.4 ms = x1.8 as fast
main
PR
Also add some PEP 8 whitespace to remove some distracting IDE warnings.