gh-126782: Support qualified referencing for ntpath.abspath()
#119849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineteendo
changed the title
ntpath.normpath() & ntpath.abspath()
nineteendo
changed the title
ntpath.normpath() & ntpath.abspath()ntpath.abspath()
…2-44-38.gh-issue-119826.Atm9ol.rst
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nineteendo
force-pushed
the
fix-ntpath.abspath
branch
from
e1d709e
to
335a737
Compare
nineteendo
requested review from
willingc,
brettcannon,
freakboy3742,
ericsnowcurrently,
erlend-aasland,
jaraco,
barneygale,
a team,
corona10,
ethanfurman and
JelleZijlstra
as code owners
erlend-aasland
requested review from
zooba
and removed request for
ncoghlan,
iritkatriel,
ericsnowcurrently,
hugovk,
pganssle,
rhettinger,
willingc,
corona10,
ethanfurman,
markshannon,
pablogsal,
erlend-aasland,
lysnikolaou,
ezio-melotti,
Fidget-Spinner,
brandtbucher,
kumaraditya303 and
AlexWaygood
|
I never rebase, when I force push it's to redo a merge commit which failed here. |
nineteendo
changed the title
ntpath.abspath()ntpath.abspath()
…024-05-31-12-44-38.gh-issue-126782.Atm9ol.rst
|
I'll fix the drive relative paths in a separate PR. |
|
Two notes:
|
|
Sorry for the chaos. |
|
It wasn't a rebase, I made a merge commit locally, but I realised I forgot to add the generated code. So I reset my head and committed without restarting the merge, causing the reviews to be requested. I force pushed afterwards to revert this commit in the hope it would remove the reviews (it didn't) with the intention of trying again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ntpath.abspath()#126782